-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves examples copy&paste-ability #97
Conversation
Also fix tomcat port
LGTM 👍 |
@@ -435,14 +435,14 @@ you could use a load generator like jmeter, or use a script such as the one show | |||
(changing URL for the URL of your load-balancer): | |||
|
|||
{% highlight bash %} | |||
$ URL=http://10.10.10.101:8000/ | |||
$ URL=http://10.10.10.101:8080/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought nginx would come up on 8000, rather than 8080 (which is the port that the first tomcat would use).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will revert.
i'd prefer a clever solution to avoiding the |
The change is not removing all |
ah of course. should we render it as:
? or i'd say to remove the leading char altogether |
I'm for the latter so it's easier to just grab it from the snippet and paste it somewhere. Otherwise you'd have the same problem as now - need to paste it somewhere intermediate to remove all those extra characters. |
@neykov if you use the clipboard icon in the corner it does that for you, though i agree if you don't know about it it's irritating -- trying to fix that |
The clipboard icon doesn't work on flash-free browsers so better not to depend on it doing the stripping. |
+1 |
and fix broken link cf apache#97
@neykov is #123 a better approach? i suspect the |
Closing in favour of #123. |
tidy curl args as discussed in #97 -- the old args looked really strange, at least on the os x `curl`. would appreciate feedback from any of @drigodwin @duncangrant @Graeme-Miller @aledsage @grkvlt who might have some insight as to whether the old args were there for a reason.
Remove
$
from line beginnings, so that the example can easily be copy&pasted in the console.Also fix tomcat port so that the example works out of the box.