Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-4238] Create a default parser configuration, to reduce redundant information in sub-parsers #2167

Merged
merged 1 commit into from
Sep 29, 2020
Merged

[CALCITE-4238] Create a default parser configuration, to reduce redundant information in sub-parsers #2167

merged 1 commit into from
Sep 29, 2020

Conversation

julianhyde
Copy link
Contributor

No description provided.

@rubenada
Copy link
Contributor

Is the appveyor error relevant? Or is it a spurious error?

julianhyde added a commit to julianhyde/calcite that referenced this pull request Sep 28, 2020
@julianhyde
[CALCITE-4238] Don't require each sub-project parser to have its own …
864cfd2 
…list of non-reserved keywords

Note that "HOP" and "TUMBLE" had been added to core/main's
nonReservedKeywords but not core/test, server, babel; that
was probably a mistake.

Close apache#2167
julianhyde added a commit to julianhyde/calcite that referenced this pull request Sep 28, 2020
@julianhyde
[CALCITE-4238] Create a default parser configuration, to reduce redun…
502a8ce 
…dant information in sub-parsers

With this change, we no longer require each sub-project
parser to have its own list of non-reserved keywords. For
example, "HOP" and "TUMBLE" had been added to core/main's
nonReservedKeywords but not core/test, server, babel; that
was probably a mistake.

Create default_config.fmpp, include it in derived parsers,
and remove properties from parsers' config.fmpp files if they
are the same as those in default_config.fmpp.

Close apache#2167
julianhyde added a commit to julianhyde/calcite that referenced this pull request Sep 28, 2020
@julianhyde
[CALCITE-4238] Create a default parser configuration, to reduce redun…
9b5018d 
…dant information in sub-parsers

With this change, we no longer require each sub-project
parser to have its own list of non-reserved keywords. For
example, "HOP" and "TUMBLE" had been added to core/main's
nonReservedKeywords but not core/test, server, babel; that
was probably a mistake.

Create default_config.fmpp, include it in derived parsers,
and remove properties from parsers' config.fmpp files if they
are the same as those in default_config.fmpp.

Close apache#2167
@julianhyde
[CALCITE-4238] Create a default parser configuration, to reduce redun…
0b2dfb7 
…dant information in sub-parsers

With this change, we no longer require each sub-project
parser to have its own list of non-reserved keywords. For
example, "HOP" and "TUMBLE" had been added to core/main's
nonReservedKeywords but not core/test, server, babel; that
was probably a mistake.

Create default_config.fmpp, include it in derived parsers,
and remove properties from parsers' config.fmpp files if they
are the same as those in default_config.fmpp.

Close apache#2167
@julianhyde julianhyde merged commit 0b2dfb7 into apache:master Sep 29, 2020
MalteBellmann pushed a commit to caespes/calcite that referenced this pull request Feb 21, 2021
@julianhyde @MalteBellmann
[CALCITE-4238] Create a default parser configuration, to reduce redun…
dae0822 
…dant information in sub-parsers

With this change, we no longer require each sub-project
parser to have its own list of non-reserved keywords. For
example, "HOP" and "TUMBLE" had been added to core/main's
nonReservedKeywords but not core/test, server, babel; that
was probably a mistake.

Create default_config.fmpp, include it in derived parsers,
and remove properties from parsers' config.fmpp files if they
are the same as those in default_config.fmpp.

Close apache#2167
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Jun 18, 2021
@julianhyde @jamesstarr
[CALCITE-4238] Create a default parser configuration, to reduce redun…
2898b55 
…dant information in sub-parsers

With this change, we no longer require each sub-project
parser to have its own list of non-reserved keywords. For
example, "HOP" and "TUMBLE" had been added to core/main's
nonReservedKeywords but not core/test, server, babel; that
was probably a mistake.

Create default_config.fmpp, include it in derived parsers,
and remove properties from parsers' config.fmpp files if they
are the same as those in default_config.fmpp.

Close apache#2167
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Jun 18, 2021
@julianhyde @jamesstarr
[CALCITE-4238] Create a default parser configuration, to reduce redun…
07db2c7 
…dant information in sub-parsers

With this change, we no longer require each sub-project
parser to have its own list of non-reserved keywords. For
example, "HOP" and "TUMBLE" had been added to core/main's
nonReservedKeywords but not core/test, server, babel; that
was probably a mistake.

Create default_config.fmpp, include it in derived parsers,
and remove properties from parsers' config.fmpp files if they
are the same as those in default_config.fmpp.

Close apache#2167

Change-Id: I6f2f6360c34a7d273f503c699c9924dfb31ecf0f
@LakshSingla LakshSingla mentioned this pull request Jan 18, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianhyde @rubenada