use ConnectTimeout for options message #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alourie
reviewed
Oct 17, 2018
| @@ -658,7 +658,7 @@ func TestQueryTimeout(t *testing.T) { | |||
| if err != ErrTimeoutNoResponse { | |||
| t.Fatalf("expected to get %v for timeout got %v", ErrTimeoutNoResponse, err) | |||
| } | |||
| case <-time.After(10*time.Millisecond + db.cfg.Timeout): | |||
| case <-time.After(40*time.Millisecond + db.cfg.Timeout): | |||
There was a problem hiding this comment.
any specific reason for 40 over 10?
There was a problem hiding this comment.
When running the stress I go a failure out of 10000 without that. I assume this was happening before as well. I don't think it will make a difference in the travis tests
There was a problem hiding this comment.
Yea, agree. Just was wondering what's happening that warrants the increase in the waiting there.
alourie
approved these changes
Oct 17, 2018
| @@ -658,7 +658,7 @@ func TestQueryTimeout(t *testing.T) { | |||
| if err != ErrTimeoutNoResponse { | |||
| t.Fatalf("expected to get %v for timeout got %v", ErrTimeoutNoResponse, err) | |||
| } | |||
| case <-time.After(10*time.Millisecond + db.cfg.Timeout): | |||
| case <-time.After(40*time.Millisecond + db.cfg.Timeout): | |||
There was a problem hiding this comment.
Yea, agree. Just was wondering what's happening that warrants the increase in the waiting there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1216