Implement job cancellation in UI #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
commented
Oct 15, 2022
| @@ -51,7 +51,7 @@ export enum QueryStatus { | |||
| export interface Query { | |||
| job_id: string; | |||
| job_name: string; | |||
| status: QueryStatus; | |||
| job_status: string; | |||
There was a problem hiding this comment.
Fix - current API doesn't return status field.
Dandandan
commented
Oct 15, 2022
| @@ -94,13 +94,20 @@ export const ActionsCell: (props: any) => React.ReactNode = (props: any) => { | |||
| }; | |||
| return ( | |||
| <Flex> | |||
| <FaStop color={"red"} title={"Stop this job"} /> | |||
| <FaStop color={"red"} title={"Stop this job"} onClick={() => { | |||
| fetch("api/job/" + props.value.job_id, { | |||
There was a problem hiding this comment.
This works succesfully - but has the "infinite loop" problem
#341
Dandandan
commented
Oct 15, 2022
| @@ -53,15 +53,6 @@ export const Header: React.FunctionComponent<HeaderProps> = ({ | |||
| <NavBarContainer> | |||
| <Flex flexDirection={"row"} alignItems={"center"}> | |||
| <img alt={"Ballista Logo"} src={Logo} /> | |||
| <Text | |||
There was a problem hiding this comment.
Seems a bit redundant, I think we can remove it here
Dandandan
commented
Oct 15, 2022
| @@ -64,7 +64,7 @@ export const Summary: React.FunctionComponent<SummaryProps> = ({ | |||
| fontWeight={"normal"} | |||
| > | |||
| <Text fontWeight={"light"} mb={2}> | |||
| General Cluster Info | |||
| Cluster Details | |||
There was a problem hiding this comment.
Not sure if text is necessary, but "Cluster Details" seems a bit more appropriate.
andygrove
approved these changes
Oct 15, 2022
There was a problem hiding this comment.
Thanks @Dandandan. I tested this locally and I could cancel a job from the UI.
I did notice a glitch though where the job shows up twice on the UI. I filed #355 to track this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #350
Rationale for this change
Implementing job cancellation in UI and some small cleanup / fixing:
What changes are included in this PR?
Are there any user-facing changes?