Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support postgres types transparently in queries #931

Closed
Kikkon opened this issue Jul 23, 2023 · 1 comment · Fixed by #933
Closed

Support postgres types transparently in queries #931

Kikkon opened this issue Jul 23, 2023 · 1 comment · Fixed by #933

Comments

@Kikkon
Copy link
Contributor

Kikkon commented Jul 23, 2023

Hi 👋
I'm following up on this: apache/datafusion#6817 and found out that some changes need to be made to sqlparser-rs, such as adding some new alias types in DataType, this change could also help sqlparser-rs to be more compatible with postgres sql, any other better suggestions? : )

@Kikkon
Copy link
Contributor Author

Kikkon commented Jul 23, 2023

Another problem: the UNSIGNED keyword doesn't exist in postgres, and BIGINT(20) isn't supported, but BIGINT in sqlparser supports both, so it seems that if we use INT8 as an alias for BIGINT, it would have to support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant