Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use Rust idiomatic capitalization for newly added DataType enums #939

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Kikkon
Copy link
Contributor

@Kikkon Kikkon commented Jul 31, 2023

In my previous commit #931 , I think the handling of case for the PostgreSQL type aliases is incorrect. We should modify it to first letter capitalized

@Kikkon Kikkon marked this pull request as ready for review July 31, 2023 14:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5716237483

  • 4 of 6 (66.67%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 87.051%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/data_type.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 82.98%
Totals Coverage Status
Change from base Build 5679999493: 0.0%
Covered Lines: 15516
Relevant Lines: 17824

💛 - Coveralls

@Kikkon
Copy link
Contributor Author

Kikkon commented Aug 7, 2023

This change is related to PostgreSQL alias types. : apache/datafusion#7156
Maybe we can merge this, then publish a release version. @alamb

@alamb alamb changed the title chore: float datatype typo Fix: use Rust idiomatic capitalization for newly added DataType enums Aug 7, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @Kikkon

@alamb alamb merged commit 173a6db into apache:main Aug 7, 2023
9 checks passed
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants