Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of datetime functions without parenthesis #930

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Jul 22, 2023

The "special" flag was missing when parsing datetime functions as special functions

Fixes #918

The "special" flag was missing
when parsing datetime functions as special functions
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5632806817

  • 17 of 18 (94.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 87.133%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 4 5 80.0%
Totals Coverage Status
Change from base Build 5621232803: -0.03%
Covered Lines: 15460
Relevant Lines: 17743

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lovasoa -- this looks great

@alamb alamb merged commit 53593f1 into apache:main Jul 26, 2023
9 checks passed
@lovasoa
Copy link
Contributor Author

lovasoa commented Jul 26, 2023

Thanks @alamb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlparser breaks CURRENT_TIMESTAMP for sqlite
3 participants