Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ALTER ROLE syntax of PostgreSQL and MS SQL Server #942

Merged
merged 6 commits into from
Aug 17, 2023
Merged

feat: add ALTER ROLE syntax of PostgreSQL and MS SQL Server #942

merged 6 commits into from
Aug 17, 2023

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Aug 9, 2023

Background

Close #941

What changes are included in this PR

  • add ALTER ROLE syntax of PostgreSQL ✅
  • add ALTER ROLE syntax of MS SQL Server ✅
  • add parser tests ✅

Addtional Context

See #941

@r4ntix r4ntix mentioned this pull request Aug 9, 2023
Open
37 tasks
alamb
alamb approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice work @r4ntix -- thank you very much for the contribution. I don't really have anything to add here. The code is nicely structured, well commented and well tested. ❤️

Thanks again

@alamb alamb merged commit a49ea19 into apache:main Aug 17, 2023
9 checks passed
@r4ntix r4ntix deleted the support-alter-role branch August 17, 2023 14:21
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@r4ntix @serprex
feat: add ALTER ROLE syntax of PostgreSQL and MS SQL Server (apache…
668333b 
…#942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ALTER ROLE syntax is not supported
2 participants
@r4ntix @alamb