Break test and coverage test into separate jobs #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 17, 2023
| @@ -75,11 +75,27 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
| - name: Test | |||
| run: cargo test --all-features | |||
|
|
|||
There was a problem hiding this comment.
The diff makes is somewhat hard to see, but I simply made a second job that runs coverage
|
Merging this one in to see how it works during the 0.38 dev cycle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: coverage takes a non trivial amount of time and does not reuse the build artifacts from normal test. Thus running them in parallel will improve the speed of CI jobs
Before this PR
With this PR the total wallclock time is less than 2m: