Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bigquery CAST AS x [STRING|DATE] FORMAT syntax #978

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Support bigquery CAST AS x [STRING|DATE] FORMAT syntax #978

merged 1 commit into from
Oct 20, 2023

Conversation

lustefaniak
Copy link
Contributor

@lustefaniak lustefaniak commented Sep 24, 2023 •
edited
Loading

@lustefaniak lustefaniak force-pushed the cast-format branch 2 times, most recently from 0d42a8a to c274bcd Compare September 25, 2023 15:50
alamb
alamb reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lustefaniak -- sorry I missed this one in the sea of reiviews. I think it is looking good in my mind -- I have some suggestions -- let me know what you think

src/ast/mod.rs Outdated Show resolved Hide resolved
src/ast/mod.rs Outdated Show resolved Hide resolved
@alamb
Copy link
Contributor

alamb commented Oct 5, 2023

I think the CI failures are not related to the changes in this PR -- if you merge up / rebase from main they should be solved. See #995

@lustefaniak lustefaniak force-pushed the cast-format branch 2 times, most recently from ebe32db to 00bd9f3 Compare October 20, 2023 09:01
@alamb alamb changed the title bigquery: CAST AS x FORMAT support Support bigquery CAST AS x FORMAT syntax Oct 20, 2023
@alamb alamb changed the title Support bigquery CAST AS x FORMAT syntax Support bigquery CAST AS x [STRING|DATE] FORMAT syntax Oct 20, 2023
alamb
alamb approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @lustefaniak

@alamb alamb merged commit c68e977 into apache:main Oct 20, 2023
10 checks passed
@lustefaniak lustefaniak deleted the cast-format branch October 20, 2023 19:14
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@lustefaniak @serprex
Support bigquery CAST AS x [STRING|DATE] FORMAT syntax (apache#978)
38b1b57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lustefaniak @alamb