Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation on Parser::consume_token and friends #994

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Improve documentation on Parser::consume_token and friends #994

merged 4 commits into from
Oct 24, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 5, 2023

I noticed the documentation on these methods could be clearer while reviewing #993 so I made a small PR to do so.

@coveralls
Copy link

coveralls commented Oct 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6626120335

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.38%
Totals Coverage Status
Change from base Build 6626095585: 0.0%
Covered Lines: 17005
Relevant Lines: 19461
💛 - Coveralls

@alamb alamb merged commit 8262abc into apache:main Oct 24, 2023
10 checks passed
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@alamb @serprex
Improve documentation on Parser::consume_token and friends (apache#994)
b6efd14
@alamb alamb deleted the alamb/improve_docs branch April 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @coveralls