Skip to content

Commit

Permalink
Sync rust docs params for CI and dev (#11890)
Browse files Browse the repository at this point in the history
Since a4ac082 commit there was a
discrepancy between rust.yml GitHub workflow and the `dev/rust_lint.sh`
script behavior. Sync the behaviors. Reuse common script to prevent
future discrepancies.
  • Loading branch information
findepi authored Aug 8, 2024
1 parent 2521043 commit 1f35b03
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,7 @@ jobs:
with:
rust-version: stable
- name: Run cargo doc
run: |
export RUSTDOCFLAGS="-D warnings"
cargo doc --document-private-items --no-deps --workspace
cd datafusion-cli
cargo doc --document-private-items --no-deps
run: ci/scripts/rust_docs.sh

linux-wasm-pack:
name: build with wasm-pack
Expand Down
2 changes: 1 addition & 1 deletion ci/scripts/rust_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# under the License.

set -ex
export RUSTDOCFLAGS="-D warnings -A rustdoc::private-intra-doc-links"
export RUSTDOCFLAGS="-D warnings"
cargo doc --document-private-items --no-deps --workspace
cd datafusion-cli
cargo doc --document-private-items --no-deps

0 comments on commit 1f35b03

Please sign in to comment.