Skip to content

Commit

Permalink
Remove IMDB(JOB) slt in CI
Browse files Browse the repository at this point in the history
Signed-off-by: Austin Liu <austin362667@gmail.com>
  • Loading branch information
austin362667 committed Oct 3, 2024
1 parent 6ee3e89 commit 6e7390f
Show file tree
Hide file tree
Showing 22 changed files with 4 additions and 729 deletions.
34 changes: 4 additions & 30 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,9 @@ jobs:
working-directory: ./datafusion/wasmtest
run: wasm-pack build --dev

# verify that tpch benchmark queries return the correct results
verify-tpch-benchmark-results:
name: verify tpch benchmark results (amd64)
# verify that the benchmark queries return the correct results
verify-benchmark-results:
name: verify benchmark results (amd64)
needs: [ linux-build-lib ]
runs-on: ubuntu-latest
container:
Expand All @@ -280,33 +280,7 @@ jobs:
export TPCH_DATA=`realpath datafusion/sqllogictest/test_files/tpch/data`
# use release build for plan verificaton because debug build causes stack overflow
cargo test plan_q --package datafusion-benchmarks --profile release-nonlto --features=ci -- --test-threads=1
INCLUDE_TPCH=true cargo test --test sqllogictests -- tpch
- name: Verify Working Directory Clean
run: git diff --exit-code

# verify that imdb benchmark queries return the correct results
verify-imdb-benchmark-results:
name: verify imdb benchmark results (amd64)
needs: [ linux-build-lib ]
runs-on: ubuntu-latest
container:
image: amd64/rust
steps:
- uses: actions/checkout@v4
with:
submodules: true
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- name: Download benchmark data and expected query results
run: |
benchmarks/bench.sh data imdb
- name: Verify that benchmark queries return expected results
run: |
INCLUDE_IMDB=true cargo test --test sqllogictests -- imdb
- name: Verify Working Directory Clean
run: git diff --exit-code
INCLUDE_TPCH=true cargo test --test sqllogictests
sqllogictest-postgres:
name: "Run sqllogictest with Postgres runner"
Expand Down
12 changes: 0 additions & 12 deletions datafusion/sqllogictest/bin/sqllogictests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,14 +231,6 @@ impl TestFile {

options.include_tpch
}

fn check_imdb(&self, options: &Options) -> bool {
if !self.relative_path.starts_with("imdb") {
return true;
}

options.include_imdb
}
}

fn read_test_files<'a>(
Expand All @@ -251,7 +243,6 @@ fn read_test_files<'a>(
.filter(|f| options.check_test_file(&f.relative_path))
.filter(|f| f.is_slt_file())
.filter(|f| f.check_tpch(options))
.filter(|f| f.check_imdb(options))
.filter(|f| options.check_pg_compat_file(f.path.as_path())),
))
}
Expand Down Expand Up @@ -305,9 +296,6 @@ struct Options {
#[clap(long, env = "INCLUDE_TPCH", help = "Include tpch files")]
include_tpch: bool,

#[clap(long, env = "INCLUDE_IMDB", help = "Include imdb files")]
include_imdb: bool,

#[clap(
action,
help = "regex like arguments passed to the program which are treated as cargo test filter (substring match on filenames)"
Expand Down
22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/1a.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/1b.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/1c.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/1d.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/2a.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/2b.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/2c.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/2d.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/3a.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/3b.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/3c.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/4a.slt.part

This file was deleted.

22 changes: 0 additions & 22 deletions datafusion/sqllogictest/test_files/imdb/4b.slt.part

This file was deleted.

Loading

0 comments on commit 6e7390f

Please sign in to comment.