Enable clippy::pedantic::large_futures lint

apache · Apr 17, 2024 · ed3774a · ed3774a
1 parent 4ad4f90
commit ed3774a
Show file tree

Hide file tree

Showing 24 changed files with 70 additions and 0 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -126,3 +126,6 @@ opt-level = 3
 overflow-checks = false
 panic = 'unwind'
 rpath = false
+
+[workspace.lints.clippy]
+large_futures = "warn"
diff --git a/benchmarks/Cargo.toml b/benchmarks/Cargo.toml
@@ -26,6 +26,9 @@ repository = { workspace = true }
 license = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [features]
 ci = []
 default = ["mimalloc"]

diff --git a/clippy.toml b/clippy.toml
@@ -6,3 +6,4 @@ disallowed-methods = [
 disallowed-types = [
     { path = "std::time::Instant", reason = "Use `datafusion_common::instant::Instant` instead for WASM compatibility" },
 ]
+future-size-threshold = 10000
diff --git a/datafusion-examples/Cargo.toml b/datafusion-examples/Cargo.toml
@@ -29,6 +29,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [[example]]
 name = "flight_sql_server"
 path = "examples/flight/flight_sql_server.rs"

diff --git a/datafusion/common-runtime/Cargo.toml b/datafusion/common-runtime/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_common_runtime"
 path = "src/lib.rs"

diff --git a/datafusion/common/Cargo.toml b/datafusion/common/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_common"
 path = "src/lib.rs"

diff --git a/datafusion/core/Cargo.toml b/datafusion/core/Cargo.toml
@@ -32,6 +32,9 @@ authors = { workspace = true }
 # https://github.com/foresterre/cargo-msrv/issues/590
 rust-version = "1.73"
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion"
 path = "src/lib.rs"

diff --git a/datafusion/execution/Cargo.toml b/datafusion/execution/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_execution"
 path = "src/lib.rs"

diff --git a/datafusion/expr/Cargo.toml b/datafusion/expr/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_expr"
 path = "src/lib.rs"

diff --git a/datafusion/functions-aggregate/Cargo.toml b/datafusion/functions-aggregate/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_functions_aggregate"
 path = "src/lib.rs"

diff --git a/datafusion/functions-array/Cargo.toml b/datafusion/functions-array/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [features]
 
 [lib]

diff --git a/datafusion/functions/Cargo.toml b/datafusion/functions/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [features]
 # enable core functions
 core_expressions = []

diff --git a/datafusion/optimizer/Cargo.toml b/datafusion/optimizer/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_optimizer"
 path = "src/lib.rs"

diff --git a/datafusion/physical-expr-common/Cargo.toml b/datafusion/physical-expr-common/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_physical_expr_common"
 path = "src/lib.rs"

diff --git a/datafusion/physical-expr/Cargo.toml b/datafusion/physical-expr/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_physical_expr"
 path = "src/lib.rs"

diff --git a/datafusion/physical-plan/Cargo.toml b/datafusion/physical-plan/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_physical_plan"
 path = "src/lib.rs"

diff --git a/datafusion/proto/Cargo.toml b/datafusion/proto/Cargo.toml
@@ -32,6 +32,9 @@ rust-version = "1.73"
 # Exclude proto files so crates.io consumers don't need protoc
 exclude = ["*.proto"]
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_proto"
 path = "src/lib.rs"

diff --git a/datafusion/proto/gen/Cargo.toml b/datafusion/proto/gen/Cargo.toml
@@ -29,6 +29,9 @@ publish = false
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
+[lints]
+workspace = true
+
 [dependencies]
 # Pin these dependencies so that the generated output is deterministic
 pbjson-build = "=0.6.2"

diff --git a/datafusion/sql/Cargo.toml b/datafusion/sql/Cargo.toml
@@ -28,6 +28,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_sql"
 path = "src/lib.rs"

diff --git a/datafusion/sqllogictest/Cargo.toml b/datafusion/sqllogictest/Cargo.toml
@@ -26,6 +26,9 @@ repository = { workspace = true }
 rust-version = { workspace = true }
 version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 name = "datafusion_sqllogictest"
 path = "src/lib.rs"

diff --git a/datafusion/substrait/Cargo.toml b/datafusion/substrait/Cargo.toml
@@ -28,6 +28,9 @@ authors = { workspace = true }
 # Specify MSRV here as `cargo msrv` doesn't support workspace version
 rust-version = "1.73"
 
+[lints]
+workspace = true
+
 [dependencies]
 async-recursion = "1.0"
 chrono = { workspace = true }

diff --git a/datafusion/wasmtest/Cargo.toml b/datafusion/wasmtest/Cargo.toml
@@ -27,6 +27,9 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [lib]
 crate-type = ["cdylib", "rlib"]
 

diff --git a/docs/Cargo.toml b/docs/Cargo.toml
@@ -28,5 +28,8 @@ license = { workspace = true }
 authors = { workspace = true }
 rust-version = { workspace = true }
 
+[lints]
+workspace = true
+
 [dependencies]
 datafusion = { workspace = true }
diff --git a/test-utils/Cargo.toml b/test-utils/Cargo.toml
@@ -22,6 +22,9 @@ edition = { workspace = true }
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
+[lints]
+workspace = true
+
 [dependencies]
 arrow = { workspace = true }
 datafusion-common = { workspace = true, default-features = true }