chore: remove DataPtr trait since Arc::ptr_eq ignores pointer metadata #10378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @intoraw and @jayzhan211 |
|
Looks like there are some more CI faiures to fix |
Oh, i'll fix it. |
|
failures are caused by DataPtr related unit tests are not removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10377.
Rationale for this change
According to rust-lang/rust#106450, Arc::ptr_eq now compares two pointer without metadata.
So, it is safe to remove DataPtr trait and use Arc::ptr_eq directly.
What changes are included in this PR?
This PR removed the DataPtr trait and replace all Arc::data_ptr_eq with Arc::ptr_eq.
Are these changes tested?
Yes
Are there any user-facing changes?
No