Enable StringView by default by passing CI #11862
Closed
+326
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
|
🤯 |
XiangpengHao
force-pushed
the
string-view-sota
branch
from
e114800
to
dc075c3
Compare
|
update here that we now pass |
github-actions
bot
added
the
documentation
|
yay finally gets a green light 🎉 |
XiangpengHao
commented
Aug 9, 2024
This was referenced Aug 16, 2024
alamb
reviewed
Aug 16, 2024
| @@ -267,7 +267,9 @@ pub(crate) fn convert_schema_to_types(columns: &Fields) -> Vec<DFColumnType> { | |||
| | DataType::Float64 | |||
| | DataType::Decimal128(_, _) | |||
| | DataType::Decimal256(_, _) => DFColumnType::Float, | |||
| DataType::Utf8 | DataType::LargeUtf8 => DFColumnType::Text, | |||
|
I have incorporated the changes related to the arrow upgrade into #12032 There are still changes in this PR related to stringview in statistics / parquet files |
This was referenced Aug 18, 2024
alamb
reviewed
Aug 22, 2024
| @@ -514,10 +521,13 @@ pub fn statistics_from_parquet_meta_calc( | |||
| statistics.total_byte_size = Precision::Exact(total_byte_size); | |||
|
|
|||
| let file_metadata = metadata.file_metadata(); | |||
| let file_schema = parquet_to_arrow_schema( | |||
| let mut file_schema = parquet_to_arrow_schema( | |||
There was a problem hiding this comment.
I messed around with this and I agree this is the least invasive change for supporting string statistics
I feel like there must be a better way, however. I will think about it
There was a problem hiding this comment.
I feel like there must be a better way, however.
I agree. I don't like passing the config around either...
There was a problem hiding this comment.
Follow up ticket filed #12123
|
Superceded by #12092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11752 and #11682
Rationale for this change
I want to make sure the remaining work to stablize
StringViewis straighforward, so I make a branch to see what it looks like with the next arrow release, and also test the performancew with it.So this PR is not meant to be merged directly, but to help people (if not me) file smaller PRs when that day (arrow release) comes
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?