Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of function migration #12743

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 3, 2024

Which issue does this PR close?

Part of #12740

Rationale for this change

@Omega359 has created the basic framework for automatically generating content in #12668

There will be a period of transition as we migrate the existing content to the new code style

We should make it it very clear what is happening during this transition period

What changes are included in this PR?

Add heading and links to the different function pages explaining the transition

Here is an example:
Screenshot 2024-10-03 at 12 59 35 PM

Are these changes tested?

Are there any user-facing changes?

Improved docs, no functional changes

@github-actions github-actions bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion logical-expr Logical plan and expressions core Core DataFusion crate functions labels Oct 3, 2024
@github-actions github-actions bot removed logical-expr Logical plan and expressions core Core DataFusion crate functions labels Oct 3, 2024
@alamb alamb marked this pull request as ready for review October 4, 2024 11:11
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented Oct 9, 2024

Thank you for the review @comphead 🙏

@Omega359
Copy link
Contributor

Omega359 commented Oct 9, 2024

lgtm as well

@alamb alamb merged commit e0b807b into apache:main Oct 9, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants