Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Convert BuiltInWindowFunction::{Lead, Lag} to a user defined window function #12857

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

wip: Convert BuiltInWindowFunction::{Lead, Lag} to a user defined window function #12857

wants to merge 50 commits into from
+340 −371

Commits on Oct 2, 2024

  1. Move lead-lag to functions-window package

    @jcsherin
    jcsherin committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9efb417 View commit details
    Browse the repository at this point in the history

  2. Builds with warnings

    @jcsherin
    jcsherin committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6f05a9c View commit details
    Browse the repository at this point in the history

  3. Adds PartitionEvaluatorArgs

    @jcsherin
    jcsherin committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d2ebd3a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Extracts shift_offset from input expressions

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e5e5ab9 View commit details
    Browse the repository at this point in the history

  2. Computes shift offset

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    303b74b View commit details
    Browse the repository at this point in the history

  3. Get default value from input expression

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    689ed3a View commit details
    Browse the repository at this point in the history

  4. Implements partition_evaluator

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0774a58 View commit details
    Browse the repository at this point in the history

  5. Fixes compiler warnings

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    009a1be View commit details
    Browse the repository at this point in the history

  6. Comments out failing tests

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8dc161f View commit details
    Browse the repository at this point in the history

  7. Fixes cargo test errors and warnings

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    45e259e View commit details
    Browse the repository at this point in the history

  8. Minor: taplo formatting

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0d2aa99 View commit details
    Browse the repository at this point in the history

  9. Delete code

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5ccb795 View commit details
    Browse the repository at this point in the history

  10. Define lead, lag user-defined window functions

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7d8b3e6 View commit details
    Browse the repository at this point in the history

  11. Fixes cargo build errors

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ba9d24a View commit details
    Browse the repository at this point in the history

  12. Export udwf and expression public APIs

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    402dcac View commit details
    Browse the repository at this point in the history

  13. Mark result field as nullable

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2ce0883 View commit details
    Browse the repository at this point in the history

  14. Delete return_type tests for lead and lag

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    95e8f87 View commit details
    Browse the repository at this point in the history

  15. Disables test: window function case insensitive

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    04f30ec View commit details
    Browse the repository at this point in the history

  16. Fixes: lowercase name in logical plan

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d034082 View commit details
    Browse the repository at this point in the history

  17. Reverts to old methods for computing shift_offset, default_value

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    513df2a View commit details
    Browse the repository at this point in the history

  18. Implements expression reversal

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bb0bd8b View commit details
    Browse the repository at this point in the history

  19. Fixes: lowercase name in logical plans

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0e576bb View commit details
    Browse the repository at this point in the history

  20. Fixes: doc test compilation errors 

    Fixes: doc test build errors
    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5490860 View commit details
    Browse the repository at this point in the history

  21. Temporarily quite clippy errors

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f0c0e72 View commit details
    Browse the repository at this point in the history

  22. Fixes proto defintion

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9051d2f View commit details
    Browse the repository at this point in the history

  23. Merge branch 'main' into convert-lead-lag-udwf

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b4cdc10 View commit details
    Browse the repository at this point in the history

  24. Minor: fixes formatting

    @jcsherin
    jcsherin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    be74322 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Fixes: doc tests

    @jcsherin
    jcsherin committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c9ac517 View commit details
    Browse the repository at this point in the history

  2. Uses macro for defining lag_udwf() and leag_udwf()

    @jcsherin
    jcsherin committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e37752f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Fixes: window fuzz test cases

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6fb12e6 View commit details
    Browse the repository at this point in the history

  2. Copies doc comments verbatim from BuiltInWindowFunction enum

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ae26cb6 View commit details
    Browse the repository at this point in the history

  3. Deletes from window function case insensitive test

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    51652d7 View commit details
    Browse the repository at this point in the history

  4. Deletes BuiltInWindowFunction expression APIs

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    723ca68 View commit details
    Browse the repository at this point in the history

  5. Delete from create_built_in_window_expr

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    742c196 View commit details
    Browse the repository at this point in the history

  6. Deletes proto serialization

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    99093f5 View commit details
    Browse the repository at this point in the history

  7. Delete from BuiltInWindowFunction enum

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0925785 View commit details
    Browse the repository at this point in the history

  8. Deletes test for finding built-in window function

    @jcsherin
    jcsherin committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6f05818 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'main' into convert-lead-lag-udwf

    @jcsherin
    jcsherin committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0be8500 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge branch 'main' into convert-lead-lag-udwf

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5854f77 View commit details
    Browse the repository at this point in the history

  2. Fixes build errors + deletes redundant code

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e69463f View commit details
    Browse the repository at this point in the history

  3. Deletes more code

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d0baa94 View commit details
    Browse the repository at this point in the history

  4. Delete unnecessary structs

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9199943 View commit details
    Browse the repository at this point in the history

  5. Refactors shift offset computation

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    000ceb7 View commit details
    Browse the repository at this point in the history

  6. Passes range unit test

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ae0b91b View commit details
    Browse the repository at this point in the history

  7. Fixes: clippy::get-first error

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a0973f9 View commit details
    Browse the repository at this point in the history

  8. Rewrite unit tests for WindowUDF

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9ddf1c9 View commit details
    Browse the repository at this point in the history

  9. Fixes: unit test for lag with default value

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3a084ed View commit details
    Browse the repository at this point in the history

  10. Consistent input expressions and data types in unit tests

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    82abc5c View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into convert-lead-lag-udwf

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d1a35d7 View commit details
    Browse the repository at this point in the history

  12. Minor: fixes formatting

    @jcsherin
    jcsherin committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e648033 View commit details
    Browse the repository at this point in the history