-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend insert into to support Parquet backed tables #7244
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b18f6ea
initial AsyncArrowWriter immplementation
devinjdangelo e52e7a0
clean up
devinjdangelo 5761062
fix information_schema test
devinjdangelo 580edaa
refactor code to new write.rs mod
devinjdangelo 1bd030e
remove config dependency on parquet crate
devinjdangelo bd8f8a8
fmt
devinjdangelo 6c0bfdb
finish implementing session write configs and parsing
devinjdangelo f10dfba
fix ndv doc
devinjdangelo 7b10881
rebase resolve conflicts
devinjdangelo 77c3f61
split up test_string_expressions into 2 tests to avoid stack overflow…
devinjdangelo bd37756
add comments explaining test split
devinjdangelo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an interesting question if we want these settings to be session level (as this change proposes) or if they should be per-sql level 🤔
I suppose having a session level default would make sense and if we want to add per statement overrides (like
COPY TO <file> AS PARQUET (DATA_PAGE_ROW_COUNT_LIMIT 100000)
) we can always do that afterwards as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will definitely want
COPY TO
to be able to set any of these configs on a per statement basis.For
insert into
, we could allow the table itself to be registered with specific settings e.g.:insert into mytable
would then use any table specific settings or fall back to the session level configs.