remove unalias TableScan filters when create Physical Filter
#8404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
jackwener
commented
Dec 3, 2023
| @@ -562,8 +562,7 @@ impl DefaultPhysicalPlanner { | |||
| // doesn't know (nor should care) how the relation was | |||
| // referred to in the query | |||
| let filters = unnormalize_cols(filters.iter().cloned()); | |||
| let unaliased: Vec<Expr> = filters.into_iter().map(unalias).collect(); | |||
There was a problem hiding this comment.
I think we have to rely on our test coverage here, and given all the existing tests pass I agree!
There was a problem hiding this comment.
Yes, existing tests already cover it.
BTW, theoretically and in terms of code, the alias in the filter expression does not affect the schema or output.
jackwener
changed the title
unalias TableScan filtersunalias TableScan filters in create PhysicalPlan
jackwener
changed the title
unalias TableScan filters in create PhysicalPlanunalias TableScan filters when create Physical Filter
alamb
approved these changes
Dec 3, 2023
| @@ -562,8 +562,7 @@ impl DefaultPhysicalPlanner { | |||
| // doesn't know (nor should care) how the relation was | |||
| // referred to in the query | |||
| let filters = unnormalize_cols(filters.iter().cloned()); | |||
| let unaliased: Vec<Expr> = filters.into_iter().map(unalias).collect(); | |||
There was a problem hiding this comment.
I think we have to rely on our test coverage here, and given all the existing tests pass I agree!
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
unaliasTableScan filtersWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?