[CI] Fix RUSTFLAGS #8929
Merged
[CI] Fix RUSTFLAGS #8929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two commit action runs with fix:
Fixes d9a1d42 For dd4263f I'm not sure if the slowdown was due to setting |
|
Basically CI times fluctuates, I saw Macos builds being 19 mins, and on the same codebase the next run 28mins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
4289737 sped win ci up, running at 33min:
Following commit dd4263f had runtime of 39min:
Subsequent runs fall around 39-42min range
Until this commit d9a1d42 which causes runtime of 47min:
Subsequent runs (up to latest main) fall around 44-48min range
What changes are included in this PR?
Fix accidental regression by d9a1d42 which named the env var incorrectly.
Are these changes tested?
Are there any user-facing changes?