Properly encode STRING_AGG, NTH_VALUE in physical plan protobufs #9027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scsmithr
added a commit
to GlareDB/glaredb
that referenced
this pull request
Jan 27, 2024
alamb
changed the title
6 tasks
|
BTW for anyone following along, this also includes tests for #9028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Attempting to encode physical plans with string_agg were erroring.
What changes are included in this PR?
Just adds in an extra downcast for encoding string_agg.
Are these changes tested?
Yes, added in a test for roundtripping.
Are there any user-facing changes?
Encoding physical plans with string_agg won't error now.