feat : Support for deregistering user defined functions #9239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobley-trent
changed the title
|
This looks good to me @mobley-trent -- do you think it is ready for review? |
|
Hey @alamb I'm done with the final touches. |
9 tasks
alamb
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Thank you @mobley-trent -- this looks great. Nicely documented and nicely tested. I had some small suggestions, but I also think they could be done as a follow on PR as well
| @@ -2247,6 +2292,196 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn register_deregister_udf() -> Result<()> { | |||
There was a problem hiding this comment.
Would it be possible to move these tests to https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/user_defined/mod.rs
Doing so would make them more discoverable as well as likely shorter as you could probably avoid having to define ScalarUDFs
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
I took the liberty of pushing a fix for |
|
Thanks again @mobley-trent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9178
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?