feat: support unnest with additional columns
#9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
alamb
approved these changes
Feb 29, 2024
| 4 2 | ||
| 5 2 | ||
| 6 3 | ||
| 12 NULL |
| let column = expr.display_name()?; | ||
|
|
||
| let unnest_column = unnest_columns.pop().unwrap(); | ||
| // Set preserve_nulls to false to ensure compatibility with DuckDB and PostgreSQL |
Thank you for the review! |
jayzhan211
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9349.
Rationale for this change
The
UnnestExecalready has this functionality.This PR passes the necessary parameters, i.e., the expressions in the select list that do not need unnesting, to it.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No