Remove physical expr of ListIndex and ListRange, convert to array_element and array_slice functions
#9492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
physical-expr
alamb
changed the title
array_element and array_slice functions
alamb
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
This is a really nice PR @jayzhan211 -- thank you so much.
Rewriting the physical expr to use a function is very clever and a very nice reduction in duplication
| @@ -119,6 +121,39 @@ impl TreeNodeRewriter for OperatorToFunctionRewriter { | |||
| }))); | |||
| } | |||
| } | |||
|
|
|||
| if let Expr::GetIndexedField(GetIndexedField { | |||
| @@ -42,61 +40,25 @@ use std::{any::Any, sync::Arc}; | |||
| pub enum GetFieldAccessExpr { | |||
| /// Named field, For example `struct["name"]` | |||
There was a problem hiding this comment.
🤔 maybe we should also convert this into a function call as well (as a follow on PR) to remove the entire GetFieldAccessExpr physical expr
|
I will file an issue to track the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Preparation of #9285
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?