Port struct to datafusion-functions
#9546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
yyy1000
commented
Mar 11, 2024
datafusion/sql/src/expr/mod.rs
Outdated
| Ok(Expr::ScalarFunction(ScalarFunction::new_udf( | ||
| Arc::new(ScalarUDF::new_from_impl( | ||
| datafusion_functions::core::r#struct::StructFunc::new(), | ||
| )), |
There was a problem hiding this comment.
Here it will use StructFunc so I add datafusion-functions as the dependency.
There was a problem hiding this comment.
One of the goals of pulling datafusion functions out of the core is so that the built in functions aren't treated specially. Thus having the sql planner directly instantiate the function goes against that goal.
Can you please change this to call the struct() function by name (get_function_meta) instead of adding a dependency
There was a problem hiding this comment.
Fixed
learn something from it :)
|
Thank you @yyy1000 for helping along the 🚂 of function extraction |
alamb
changed the title
struct to datafusion-functions
alamb
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Thank you @yyy1000 and @jayzhan211 -- this is looking great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #9285 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?