Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-7911 Increase the max direct memory #2219

Merged
merged 1 commit into from
May 10, 2021

Conversation

martin-g
Copy link
Member

@martin-g martin-g commented May 7, 2021

DRILL-7911: Increase the max direct memory

Description

It seems 2500Mb is not enough on Linux ARM64

Fixes errors like:

[ERROR] Tests run: 19, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 5.039 s <<< FAILURE! - in org.apache.drill.exec.record.vector.TestValueVector
[ERROR] org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation  Time elapsed: 0.037 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.apache.drill.exec.exception.OversizedAllocationException> but was<org.apache.drill.exec.exception.OutOfMemoryException>
	at org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)
Caused by: io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 2147483644 byte(s) of direct memory (used: 872415232, max: 2621440000)
	at org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)

Documentation

Another way to "fix" this issue is to pass -DdirectMemoryMb=3000 only for builds on Linux ARM64. In this case this will have to be documented in the README and https://drill.apache.org/docs/apache-drill-contribution-guidelines/

Testing

There are no code changes.

2500Mb is not enough on Linux ARM64

Fixes errors like:

[ERROR] Tests run: 19, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 5.039 s <<< FAILURE! - in org.apache.drill.exec.record.vector.TestValueVector
[ERROR] org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation  Time elapsed: 0.037 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.apache.drill.exec.exception.OversizedAllocationException> but was<org.apache.drill.exec.exception.OutOfMemoryException>
	at org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)
Caused by: io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 2147483644 byte(s) of direct memory (used: 872415232, max: 2621440000)
	at org.apache.drill.exec.record.vector.TestValueVector.testFixedVectorReallocation(TestValueVector.java:107)
@martin-g
Copy link
Member Author

martin-g commented May 7, 2021

I just found out that Github Actions CI uses 4500M -

run: mvn install -DdirectMemoryMb=4500 -DmemoryMb=1300

Maybe this value should be used in pom.xml ?

@luocooong luocooong added the arm-based PRs get Drill to run on ARM label May 7, 2021
Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm-based PRs get Drill to run on ARM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants