Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR UPDATE]: Add an .editorconfig file providing style hints to editors and IDEs #2281

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

jnturton
Copy link
Contributor

Description

Non-code change.

EditorConfig (https://editorconfig.org/) is an editor-neutral file format
that holds code style settings. This particular config has been defined
to reflect the style convetions in the Drill codebase (most significantly,
indentation is with 2 spaces). Many mainstream editors and IDEs will
recognise this file and set themselves up accordingly, making it easier to
contribute code following the project's conventions. Editors that do not
understand EditorConfig are unaffected.

Note that .editorconfig only contains global conventions for the codebase, not
individual users' editor preferences, which must be masked by .gitignore.
Other Apache projects with a .editorconfig file in their code repo are
Superset, Subversion, Thrift, Submarine and presumably some more.

EditorConfig (https://editorconfig.org/) is an editor-neutral file format
that holds code style settings.  This particular config has been defined
to reflect the style convetions in the Drill codebase (most significantly,
indentation is with 2 spaces).  Most mainstream editors and IDEs will
recognise this file and set themselves up accordingly, making it easier to
contribute code following the project's conventions.

Note that .editorconfig only contains global conventions for codebase, not
individual users' editor preferences, which must be masked by .gitignore.
Other Apache projects with a .editorconfig file in their code repo are
Superset, Subversion, Thrift, Submarine and presumably some more.
@luocooong
Copy link
Member

@dzamo
Error: Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (rat-checks) on project drill-root: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/drill/drill/target/rat.txt -> [Help 1]

Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzamo Thanks for the PR. Could you please exclude this file from the RAT check or add the appropriate license to the file. Once that's done, LGTM +1

Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either add license or exclude this file from the license check.

@jnturton
Copy link
Contributor Author

Thanks, I've added the Apache license.

@jnturton jnturton requested a review from cgivre July 30, 2021 10:38
Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@jnturton jnturton merged commit e73bf9a into apache:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants