Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests! #8

Closed
cheddar opened this issue Oct 29, 2012 · 2 comments
Closed

Unit Tests! #8

cheddar opened this issue Oct 29, 2012 · 2 comments
Assignees
@cheddar
Milestone
0.4.32 and before

Comments

@cheddar
Copy link
Contributor

cheddar commented Oct 29, 2012

The current code base is missing a lot of Unit Tests, it's almost as if it isn't tested. This is an artifact of the separation from our proprietary code base, it turns out that a lot of the unit tests depended on things that are metamx-specific, so we need to port those tests from our internal repo back into the code base.
@ghost ghost assigned cheddar Oct 29, 2012
@cheddar
Copy link
Contributor Author

cheddar commented Nov 19, 2012

This has been rectified to a certain extent. We still need to add unit tests for GroupBy queries.

cheddar added a commit that referenced this issue Nov 21, 2012
@cheddar
1) Fix PostAggregations with GroupBy (Fixes #24)
06b8e42 
2) Add GroupByTimeseriesQueryRunnerTest which wraps a GroupByQueryRunner to look like a TimeseriesQueryRunner and leverages the tests there to help verify behavior (#8)
@cheddar
Copy link
Contributor Author

cheddar commented Mar 13, 2013

This has been done!

@cheddar cheddar closed this as completed Mar 13, 2013
cheddar pushed a commit to cheddar/druid that referenced this issue Jul 1, 2015
Merge pull request apache#8 from himanshg/digits_pkg_config_updates
a848420 
druid yinst config updates to enable caching and read timeout
guobingkun pushed a commit to guobingkun/druid that referenced this issue Dec 21, 2015
build apache#8
627c311
clintropolis pushed a commit to clintropolis/druid that referenced this issue Dec 20, 2023
@pranavbhole
Merge pull request apache#8 from pranavbhole/scanQuery
d4044ef 
Enable Scan query metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheddar cheddar

Labels
None yet
Projects
None yet
Milestone
0.4.32 and before
Development

No branches or pull requests
1 participant
@cheddar