fix JettyTest would fail if JettyWithResponseFilterEnabledTest ran before it #11803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabledTest ran before it this change ensures that JettyTest is setting the properties it needs in case some other test overwrites them this also changes up the ordering of the call for setProperties to call super's first in case super is setting the same property
clintropolis
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this change ensures that
JettyTestis setting the properties it needs in case some other test overwrites themIt also changes up the ordering of the call for
setPropertiesto call super's first in case super is setting the same property as the class setting it.I could have changed the
JettyWithResponseFilterEnabledTestto clean up after itself, but some other test could come in and do a similar change and breakJettyTestagain. By makingJettyTestin charge of its own dependencies it is a more resilient test.Key changed/added classes in this PR
JettyTestJettyWithResponseFilterEnabledTestThis PR has: