set log4j2.is.webapp to false if not set so that shutdown hooks are run #12056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonson
approved these changes
Dec 11, 2021
jihoonson
approved these changes
Dec 11, 2021
gianm
approved these changes
Dec 11, 2021
nikhil-ddu
pushed a commit
to twitter-forks/druid
that referenced
this pull request
Dec 13, 2021
…un (apache#12056) * set log4j2.is.webapp to false if not set so that shutdown hooks are run
nikhil-ddu
pushed a commit
to twitter-forks/druid
that referenced
this pull request
Dec 13, 2021
…un (apache#12056) * set log4j2.is.webapp to false if not set so that shutdown hooks are run
CodingParsley
pushed a commit
to confluentinc/druid
that referenced
this pull request
Jan 24, 2022
…un (apache#12056) * set log4j2.is.webapp to false if not set so that shutdown hooks are run
CodingParsley
added a commit
to confluentinc/druid
that referenced
this pull request
Jan 24, 2022
…un (apache#12056) (#65) * set log4j2.is.webapp to false if not set so that shutdown hooks are run Co-authored-by: Clint Wylie <cwylie@apache.org>
debasatwa29
pushed a commit
to debasatwa29/druid
that referenced
this pull request
Jun 2, 2022
…ilities Summary: Druid is running with JVM 1.8.0_232 but log4j 2.5 so it's P1 rather than p0. Pull upstream to upgrade log4j to 2.15.0 to address security vulnerabilities Changes are from the following upstream PRs: # Upgrade log4j from 2.8.2 to 2.15.0 apache#12051 apache#12056 # Upgrade log4j from 2.5 to 2.8.2 apache#8878 Reviewers: O1139 Druid, jgu, itallam Reviewed By: O1139 Druid, jgu, itallam Subscribers: jenkins, shawncao, #realtime-analytics Differential Revision: https://phabricator.pinadmin.com/D823708
anishanagarajan
pushed a commit
to twitter-forks/druid
that referenced
this pull request
Sep 23, 2022
…un (apache#12056) * set log4j2.is.webapp to false if not set so that shutdown hooks are run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating in log4j2 in #12051, errors when shutting down services and tasks appear of the form
and shutdown hooks are not run.
This is because by default
log4j2.is.webappis set totrueif it detectsjavax.servlet.Servletorjakarta.servlet.Servleton the classpath, and shutdown hooks are disabled for web-apps in apache/logging-log4j2@b59819eThis PR makes shutdown hooks work again by automatically setting this to false if it is not explicitly set in system properties (similar to the shutdown hook properties themselves). I don't think this should have any impact on Druid since we are not technically a web app, and this setting only appears to be used by a few jmx related settings.