Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in s3 docs. add readme to s3 module. #14135

Merged
merged 4 commits into from
Apr 26, 2023
Merged

fix typo in s3 docs. add readme to s3 module. #14135

merged 4 commits into from
Apr 26, 2023

Conversation

TSFenwick
Copy link
Contributor

@TSFenwick TSFenwick commented Apr 20, 2023 •
edited
Loading

Fixes typo in s3 docs.

Description

fixes typo in s3 docs, also adds a readme in the extension to link to the docs.

Release note

Key changed/added classes in this PR
  • extensions-core/s3-extensions/README.md

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

317brian
317brian approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 really minor nit that doesn't affect anything. LGTM

extensions-core/s3-extensions/README.md Outdated Show resolved Hide resolved
@TSFenwick @317brian
Update extensions-core/s3-extensions/README.md
b79d075 
Co-authored-by: 317brian <53799971+317brian@users.noreply.github.com>
amaechler
amaechler approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@amaechler amaechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐻

extensions-core/s3-extensions/README.md Outdated Show resolved Hide resolved
@TSFenwick TSFenwick marked this pull request as ready for review April 26, 2023 17:19
suneet-s
suneet-s approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this README @TSFenwick !

@suneet-s suneet-s merged commit 6c99fbe into apache:master Apr 26, 2023
@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaechler amaechler amaechler approved these changes

@suneet-s suneet-s suneet-s approved these changes

@317brian 317brian 317brian approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
27.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TSFenwick @amaechler @suneet-s @317brian @abhishekagarwal87