Add logging for task stop operations #14192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indexing-service/src/main/java/org/apache/druid/indexing/worker/executor/ExecutorLifecycle.java
Outdated
Show resolved
Hide resolved
findingrish
changed the title
| .onHttpError(e -> Either.value(false)) | ||
| .onNotAvailable(e -> Either.value(false)) | ||
| .onHttpError(e -> { | ||
| log.warn("Task [%s] coundln't be stopped because of http request failure.", id); |
There was a problem hiding this comment.
we also want to log what this failure was. is it something that e.getMessage will have?
| return Either.value(false); | ||
| }) | ||
| .onNotAvailable(e -> { | ||
| log.warn("Task [%s] coundln't be stopped because it is not available.", id); |
There was a problem hiding this comment.
what does being "not available" exactly mean here? The task port is not reachable?
There was a problem hiding this comment.
this corresponds to ServiceNotAvailableException which is thrown when the service locator returns empty set of locations
| return isSuccess(response); | ||
| boolean isSuccess = isSuccess(response); | ||
| if (!isSuccess) { | ||
| log.warn("Task [%s] coundln't be stopped because of http request failure.", id); |
There was a problem hiding this comment.
is it possible to get the exact http request failure?
abhishekagarwal87
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.