Add method to authorize native query using authentication result #14376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findingrish
changed the title
gianm
reviewed
Jun 6, 2023
| * @param authenticationResult authentication result indicating identity of the requester | ||
| * @return authorization result of requester | ||
| */ | ||
| public Access authorize(AuthenticationResult authenticationResult) |
There was a problem hiding this comment.
Please include some unit tests for this new method, in case it's called directly.
There was a problem hiding this comment.
I have updated the existing tests for authorize(HttpServletRequest) to also test this method.
abhishekagarwal87
approved these changes
Jun 12, 2023
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Jun 20, 2023
…ult (apache#14376)" This reverts commit 8b212e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.