Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak GHA runner label for MSQ #14992

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

LakshSingla
Copy link
Contributor

@LakshSingla LakshSingla commented Sep 14, 2023

Modifies the following things:

  1. Uses label Area - MSQ instead of MSQ to keep it consistent with other label types and the past labels used for MSQ
  2. Change the scope the Area - Querying label to changes contained in the sql package in MSQ

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@LakshSingla LakshSingla merged commit 0fc5d54 into apache:master Sep 15, 2023
73 of 74 checks passed
@LakshSingla LakshSingla deleted the tweak-msq-gha-label branch September 15, 2023 05:44
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants