Rename the default setting of 'maxSubqueryBytes' from 'unlimited' to 'disabled' #15108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
approved these changes
Oct 9, 2023
docs/configuration/index.md
Outdated
| @@ -1871,6 +1871,11 @@ Note the following guardrails that can be set by the cluster admin to limit the | |||
|
|
|||
| Note that limiting the subquery by bytes is a newer feature therefore it is experimental as it materializes the results differently. | |||
|
|
|||
| 'maxSubqueryBytes' can be configured to following values: | |||
There was a problem hiding this comment.
We should also document stuff in QueryContext.md#General parameters.
| 1. 'disabled' - It is the default setting out of the box. It disables the subquery's from the byte based limit, and effectively disables this feature. | ||
| 2. 'auto' - Druid automatically decides the optimal byte based limit based upon the heap space available and the max number of concurrent queries. | ||
| 3. A postive long value - User can manually specify the number of bytes that the results of the subquerys of a single query can occupy on the heap. | ||
|
|
There was a problem hiding this comment.
Please mention the side effects as well that in terms of when the performance starts degrading.
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
Oct 16, 2023
…'disabled' (apache#15108) The default setting of 'maxSubqueryBytes' is renamed from 'unlimited' to 'disabled'.
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
…'disabled' (apache#15108) The default setting of 'maxSubqueryBytes' is renamed from 'unlimited' to 'disabled'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the value of the default setting of 'maxSubqueryBytes' from 'unlimited' to 'disabled' since the latter is more depictive of what happens.
Release note
The default setting of 'maxSubqueryBytes' is renamed from 'unlimited' to 'disabled'.
When the user sets 'maxSubqueryBytes'='disabled`, the guard rail around subQuery row bytes is not applied.
Key changed/added classes in this PR
This PR has: