start process of deprecating non-sql compatible legacy configurations #15713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: * officially deprecate non SQL compatible modes by updating docs to aggressively call out that Druids non SQL compliant modes are deprecated and will go away someday
abhishekagarwal87
approved these changes
Feb 6, 2024
docs/querying/sql-data-types.md
Outdated
| string. While the `COUNT(*)` aggregator counts all rows, the `COUNT(expr)` aggregator counts the number of rows | ||
| where `expr` is neither null nor the empty string. Numeric columns in this mode are not nullable; any null or missing | ||
| values are treated as zeroes. This was the default prior to Druid 28.0.0. | ||
| When `druid.generic.useDefaultValueForNull = true` (legacy), Druid treats NULLs and empty strings interchangeably, |
There was a problem hiding this comment.
Suggested change
| When `druid.generic.useDefaultValueForNull = true` (legacy), Druid treats NULLs and empty strings interchangeably, | |
| When `druid.generic.useDefaultValueForNull = true` (deprecated legacy mode), Druid treats NULLs and empty strings interchangeably, |
LakshSingla
pushed a commit
to LakshSingla/druid
that referenced
this pull request
Feb 13, 2024
…apache#15713) Starting the process to officially deprecate non SQL compatible modes by updating docs to aggressively call out that Druids non SQL compliant modes are deprecated and will go away someday. There are no code or behavior changes at this PR.
LakshSingla
added a commit
that referenced
this pull request
Feb 13, 2024
…#15713) (#15895) Starting the process to officially deprecate non SQL compatible modes by updating docs to aggressively call out that Druids non SQL compliant modes are deprecated and will go away someday. There are no code or behavior changes at this PR. Co-authored-by: Clint Wylie <cwylie@apache.org>
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Feb 20, 2024
…apache#15713) Starting the process to officially deprecate non SQL compatible modes by updating docs to aggressively call out that Druids non SQL compliant modes are deprecated and will go away someday. There are no code or behavior changes at this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting the process to officially deprecate non SQL compatible modes by updating docs to aggressively call out that Druids non SQL compliant modes are deprecated and will go away someday. There are no code or behavior changes at this PR.
Dev list thread: https://lists.apache.org/thread/016nqtdbjlkfy3r5bnxc2d4rmt79237j
This PR has: