Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Window operators in decoupled planning #15815

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

kgyrtkirk
Copy link
Member

Description

  • move baseruleset into a separate program
    • it doesn't interfere with the conversion rules
    • there will be less states in the planner during the conversion
  • enable scan&sort style queries to accept column reordings
  • add Window related conversion/etc to enable it in decoupled mode
  • added DecoupledTestConfig to specify per-testcase customization
    • currently its being used to describe why the native query is not checked

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

* move baseruleset into a separate program
  * it doesn't interfere with the conversion rules
  * there will be less states in the planner during the conversion
* enable scan&sort style queries to accept column reordings
* add Window related conversion/etc to enable it in decoupled mode
* added `DecoupledTestConfig` to specify per-testcase customization
  * currently its being used to describe why the native query is not checked
Copy link
Member

@rohangarg rohangarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there have been a couple of plans which regressed but we can take up that effort later on.

@rohangarg rohangarg merged commit fdc7cec into apache:master Feb 7, 2024
83 checks passed
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants