Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization bug in PassthroughAggregatorFactory #15830

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix serialization bug in PassthroughAggregatorFactory #15830

merged 1 commit into from
Feb 5, 2024

Conversation

LakshSingla
Copy link
Contributor

@LakshSingla LakshSingla commented Feb 3, 2024 •
edited
Loading

Description

PassthroughAggregatorFactory overrides a deprecated method in the AggregatorFactory, on which it relies on for serializing one of its fields complexTypeName. This was accidentally removed, leading to a bug in the factory, where the type name doesn't get serialized properly, and places null in the type name. This PR revives that method with a different name and adds tests for the same.

Key changed/added classes in this PR
  • PassthroughAggregatorFactory

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Feb 3, 2024
@abhishekagarwal87 abhishekagarwal87 added this to the 29.0.0 milestone Feb 5, 2024
@abhishekagarwal87 abhishekagarwal87 merged commit ee78a03 into apache:master Feb 5, 2024
53 checks passed
@LakshSingla LakshSingla deleted the inc-index-npe branch February 6, 2024 06:16
LakshSingla added a commit to LakshSingla/druid that referenced this pull request Feb 6, 2024
@LakshSingla
Fix serialization bug in PassthroughAggregatorFactory (apache#15830)
700acd5 
PassthroughAggregatorFactory overrides a deprecated method in the AggregatorFactory, on which it relies on for serializing one of its fields complexTypeName. This was accidentally removed, leading to a bug in the factory, where the type name doesn't get serialized properly, and places null in the type name. This PR revives that method with a different name and adds tests for the same.
@LakshSingla LakshSingla mentioned this pull request Feb 6, 2024
Merged
abhishekagarwal87 pushed a commit that referenced this pull request Feb 7, 2024
@LakshSingla
Fix serialization bug in PassthroughAggregatorFactory (#15830) (#15841)
9bf5e1b 
PassthroughAggregatorFactory overrides a deprecated method in the AggregatorFactory, on which it relies on for serializing one of its fields complexTypeName. This was accidentally removed, leading to a bug in the factory, where the type name doesn't get serialized properly, and places null in the type name. This PR revives that method with a different name and adds tests for the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

Assignees
No one assigned
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262
Projects
None yet
Milestone
29.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LakshSingla @abhishekagarwal87