allow for kafka-emitter to have extra dimensions be set for each event it emits #15845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
running this locally to verify it works as expected |
dkoepke
reviewed
Feb 6, 2024
abhishekrb19
reviewed
Feb 6, 2024
abhishekrb19
reviewed
Feb 6, 2024
...s-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitterConfig.java
Outdated
Show resolved
Hide resolved
...s-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitterConfig.java
Show resolved
Hide resolved
| @@ -117,7 +120,7 @@ public void testSerDeNotRequiredKafkaProducerConfigOrKafkaSecretProducer() | |||
| { | |||
| KafkaEmitterConfig kafkaEmitterConfig = new KafkaEmitterConfig("localhost:9092", null, "metricTest", | |||
| "alertTest", null, "metadataTest", | |||
| "clusterNameTest", null, null | |||
| "clusterNameTest", null, null, null | |||
There was a problem hiding this comment.
For code coverage, maybe make this non-null or add a new test with a non-null extra dimension map?
abhishekrb19
reviewed
Feb 6, 2024
zachjsh
reviewed
Feb 6, 2024
abhishekrb19
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
LGTM. +1 after CI (checkstyle is failing), thanks @TSFenwick!
|
Ignoring the unrelated IT failure: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow for extra dimensions to be set in the kafka emitter. This functionality will allow the clusterName config for kafka-emitter to not need to necessarily be used as this new config allows for more flexibility to add n different dimensions.
Also made various nullable/nonnull annotation fixes
Release note
User configurable dimensions can be set via
druid.emitter.kafka.extra.dimensionsfor events emitted by KafkaEmitter. For example,druid.emitter.kafka.extra.dimensions={"region":"us-east-1","environment":"preProd"}.Key changed/added classes in this PR
KafkaEmitterKafkaEmitterConfigThis PR has: