Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove aws-sdk from ranger-extension #16011

Merged
merged 8 commits into from
Mar 8, 2024
Merged

remove aws-sdk from ranger-extension #16011

merged 8 commits into from
Mar 8, 2024

Conversation

janjwerner-confluent
Copy link
Contributor

Fixes # size blowup regression introduced in #15443

Description

This PR removes the transitive dependency of ranger-plugins-audit to reduce the size of the compiled artifacts

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@LakshSingla
Copy link
Contributor

Is it safe to exclude the dependency? Last I checked, the ranger did rely on AWS Cloudwatch for some things. Do we not use that functionality in Druid?

xvrl
xvrl approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@xvrl xvrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once static checks / tests pass.

@abhishekagarwal87
Copy link
Contributor

why does the description says "azure-sdk"?

@janjwerner-confluent janjwerner-confluent changed the title remove azure-sdk from ranger-extension remove aws-sdk from ranger-extension Mar 5, 2024
@janjwerner-confluent
Copy link
Contributor Author

why does the description says "azure-sdk"?

brain freeze I guess, fixed it :)

@xvrl xvrl merged commit a7b2747 into apache:master Mar 8, 2024
12 checks passed
@janjwerner-confluent janjwerner-confluent deleted the remove-azure-sdk-from-ranger branch March 8, 2024 15:46
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
@adarshsanjeev adarshsanjeev mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xvrl xvrl xvrl approved these changes

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

Assignees
No one assigned
Labels
Area - Dependencies
Projects
None yet
Milestone
30.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janjwerner-confluent @LakshSingla @abhishekagarwal87 @xvrl @adarshsanjeev