Fix numSegmentsKilled metric
#16103
Merged
Fix numSegmentsKilled metric
#16103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachjsh
approved these changes
Mar 12, 2024
|
LGTM, question: in this case, how does the orphaned segment whose metadata was deleted but data remaings in deep storage get cleaned up from deep storage, does it ever? Or is this a bug? |
AFAIK, the orphan segments need to be manually cleaned up from the deep storage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the KillTaskReport contained the
numSegmentsKilledmetric, representing the size of unused segments nuked from the metadata store, rather than the actual number of segments killed from deep storage. For instance, there may be cases where an unused segment won't be killed from deep storage if its load spec is in use by another segment. In such cases, only the metadata will be cleaned up. This patch contains a test for this scenario.Alternatively and at the very least to avoid any confusion, we can capture both the number of nuked segments from the metadata store and the number of segments killed from deep storage as separate metrics in the KillTaskReport.
This PR has: