-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error messages when supervisor's checkpoint state is invalid #16208
Merged
abhishekrb19
merged 7 commits into
apache:master
from
abhishekrb19:update_supervisor_topic_error
Apr 3, 2024
Merged
Update error messages when supervisor's checkpoint state is invalid #16208
abhishekrb19
merged 7 commits into
apache:master
from
abhishekrb19:update_supervisor_topic_error
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggest resetting the supervisor when the topic changes instead of changing the supervisor name which is actually making a new supervisor.
kfaraz
reviewed
Mar 27, 2024
server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
Outdated
Show resolved
Hide resolved
…ataStorageCoordinator.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
abhishekrb19
changed the title
Suggest resetting a supervisor when the topic is updated
Update error messages when supervisor's checkpoint state is invalid
Apr 3, 2024
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
Fixed
Show fixed
Hide fixed
kfaraz
approved these changes
Apr 3, 2024
@@ -2395,17 +2388,19 @@ protected DataStoreMetadataUpdateResult updateDataSourceMetadataWithHandle( | |||
} | |||
|
|||
final boolean startMetadataMatchesExisting; | |||
int startMetadataGreaterThanExisting = 0; | |||
boolean startMetadataGreaterThanExisting = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the topic name for a supervisor results in the following error:
Changing the supervisor's name makes it a completely different supervisor. Update the error message to instead suggest resetting the supervisor as the primary way to fix it when this happens. The updated error message is as follows:
Other cleanup changes:
startMetadataGreaterThanExisting
from an integer to boolean type to make the intent clear.DruidException
instead ofRuntimeException
inSegmentPublishResult
failure calls.SegmentPublishResult
error itself.This PR has: