Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use created time from metadata store to list multiple active tasks #16228

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Use created time from metadata store to list multiple active tasks #16228

merged 1 commit into from
Apr 3, 2024

Conversation

AmatyaAvadhanula
Copy link
Contributor

Description

The web-console of getTasks API can return incorrect created times and durations afte the Overlord restarts. This is because we populate the field with the time at which the task was added to the TaskRunner for active tasks.

Fix

The method now uses the created_date field from the metadata store as should have been the case for all tasks. No additional calls have been added.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@AmatyaAvadhanula AmatyaAvadhanula changed the title Use created time from metadata store in the method to list multiple active tasks Use created time from metadata store to list multiple active tasks Apr 2, 2024
kfaraz
kfaraz approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@AmatyaAvadhanula AmatyaAvadhanula merged commit 218513a into apache:master Apr 3, 2024
83 of 85 checks passed
@AmatyaAvadhanula
Copy link
Contributor Author

Thank you for the review @kfaraz!
Merged as the failing checks were unrelated.

@kfaraz kfaraz deleted the fix_time_list_active_tasks branch April 30, 2024 09:13
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
@adarshsanjeev adarshsanjeev mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfaraz kfaraz kfaraz approved these changes

Assignees
No one assigned
Labels
Area - Ingestion
Projects
None yet
Milestone
30.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmatyaAvadhanula @kfaraz @adarshsanjeev