Improve logging for lookups #16287
Merged
Improve logging for lookups #16287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
Apr 16, 2024
| @@ -394,7 +394,7 @@ private List<LookupBean> getLookupsList() | |||
| if (lookupConfig.getEnableLookupSyncOnStartup()) { | |||
| lookupBeanList = getLookupListFromCoordinator(lookupListeningAnnouncerConfig.getLookupTier()); | |||
| if (lookupBeanList == null) { | |||
| LOG.info("Coordinator is unavailable. Loading saved snapshot instead"); | |||
| LOG.info("No lookup list found from coordinator. Loading saved snapshot instead"); | |||
There was a problem hiding this comment.
Slight rephrase:
Suggested change
| LOG.info("No lookup list found from coordinator. Loading saved snapshot instead"); | |
| LOG.info("Could not fetch lookups from the coordinator. Loading saved snapshot instead."); |
kfaraz
approved these changes
Apr 16, 2024
|
Merging as IT failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Coordinator is unavailable" overstates the problem here. This gets logged even when the coordinator is available but no lookups have been configured.
Changed log message from "Coordinator is unavailable" to "Could not fetch lookups from the coordinator"
Release note
Improved logging when ingestion tasks try to get lookups from the coordinator at startup
If your change doesn't have end user impact, you can skip this section.
For tips about how to write a good release note, see Release notes.
-->
Key changed/added classes in this PR
LookupReferencesManagerThis PR has: