Disable upload of coverage report to codecov.io

[kfaraz]

Description

Build of recent PRs is getting stuck due to rate limiting of the codecov.io API. The unit test job just keeps retrying to connect.

{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 153 seconds.', code='throttled')}
{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 0 seconds.', code='throttled')}
{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 3598 seconds.', code='throttled')}
{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 3598 seconds.', code='throttled')}
{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 0 seconds.', code='throttled')}
{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue.

Sample failing job:
https://github.com/apache/druid/actions/runs/8875278501/job/24364864254?pr=15705

Fix

In unit_tests_script.sh , disable upload of coverage report to codecov.io.

Impact

No one in the Druid community seems to be using the codecov visualization to analyse code coverage.
Most contributors look at the reports generated by jacoco itself and use that to ensure full coverage.

In the future, if we feel the need to re-enable it we may uncomment the code.

[cryptoe]

Since this is a development blocker we can merge this.
I think its not needed any more since the objective from this PR : #8388 is codecov should comment on github PR's which have low coverage. The feature is turned off here :

druid/.codecov.yml

Line 24 in 5061507

comment: off

[kfaraz]

Thanks for the confirmation and the swift review, @cryptoe !

[amaechler]

Should we remove the coverage button from the README too?

[kgyrtkirk]

+1 on disabling it

I've tried to search for a few classes I would expect to have some test coverage DruidQuery and CoalesceLookupRule neither of them showed up...

I wonder if this thing used by anyone?

[kfaraz]

Should we remove the coverage button from the README too?

Thanks for calling this out, @amaechler ! I am merging this PR to unblock development, will remove the button in a follow up.

Thanks for the feedback, @cryptoe , @kgyrtkirk !