Clean up allocation and supervisor logs for easier debugging #16535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
Show resolved
Hide resolved
AmatyaAvadhanula
approved these changes
Jun 3, 2024
|
Thanks for the quick review, @AmatyaAvadhanula ! |
gargvishesh
suggested changes
Jun 3, 2024
...g-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java
Outdated
Show resolved
Hide resolved
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
Outdated
Show resolved
Hide resolved
gargvishesh
reviewed
Jun 3, 2024
| .mapToInt(List::size).sum(); | ||
| if (numPendingCompletionTaskGroups + numStoppedTasks.get() < ioConfig.getMaxAllowedStops()) { | ||
| log.info( | ||
| "Stopping taskGroup[%d] as it has already run for duration[%s], configured task duration[%s].", |
There was a problem hiding this comment.
No, units are not required since the object being printed is a duration and would be formatted something like PT1800S, etc.
Co-authored-by: Vishesh Garg <vishesh.garg@imply.io>
gargvishesh
approved these changes
Jun 3, 2024
|
Thanks for the review, @gargvishesh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
taskGroupconsistently to easily search for a task group