Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect comparator usage in FinalizingFieldAccessPostAggregator #16555

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
add serde for histo
  • Loading branch information
kgyrtkirk committed Jun 7, 2024
commit f0a11125c99e819880126fc93a8232a390f0eaad
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,6 @@ public static void registerSerde()
{
ComplexMetrics.registerSerde(ApproximateHistogramFoldingSerde.TYPE_NAME, new ApproximateHistogramFoldingSerde());
ComplexMetrics.registerSerde(FixedBucketsHistogramAggregator.TYPE_NAME, new FixedBucketsHistogramSerde());
ComplexMetrics.registerSerde(Histogram.TYPE.getComplexTypeName(), new HistogramSerde2());
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.druid.query.aggregation.histogram;

import org.apache.druid.error.DruidException;
import org.apache.druid.query.aggregation.BasicComplexMetricSerde;
import org.apache.druid.segment.data.ObjectStrategy;
import java.nio.ByteBuffer;

public class HistogramSerde2 extends BasicComplexMetricSerde<Histogram>
{
public HistogramSerde2()
{
super(Histogram.TYPE, new HistogramObjectStrategy());
}

static class HistogramObjectStrategy implements ObjectStrategy<Histogram>
{

@Override
public int compare(Histogram o1, Histogram o2)
{
return 0;
}

@Override
public Class<? extends Histogram> getClazz()
{
return Histogram.class;
}

@Override
public Histogram fromByteBuffer(ByteBuffer buffer, int numBytes)
{
throw DruidException.defensive("not supported");
}

@Override
public byte[] toBytes(Histogram val)
{
throw DruidException.defensive("not supported");
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@

public class ApproximateHistogramAggregatorTest extends InitializedNullHandlingTest
{
static {
ApproximateHistogramDruidModule.registerSerde();
}

private void aggregateBuffer(TestFloatColumnSelector selector, BufferAggregator agg, ByteBuffer buf, int position)
{
agg.aggregate(buf, position);
Expand Down
Loading