Fix sql syntax error user #16583
Merged
Fix sql syntax error user #16583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -380,13 +380,7 @@ public static DruidException translateException(Exception e) | |||
| } | |||
| } | |||
|
|
|||
| return DruidException.forPersona(DruidException.Persona.DEVELOPER) | |||
There was a problem hiding this comment.
This makes sense to me since this is still a case of SqlParseException.
@zachjsh, do you mind adding a test with a bad SQL that would cause the exception to be targeted towards a user?
kgyrtkirk
reviewed
Jun 11, 2024
Comment on lines
688
to
689
| // For this reason, we consider these as targetting a more expert persona, i.e. the admin instead of the actual | ||
| // user. |
There was a problem hiding this comment.
The removed comment provides the reason why it was not target to the USER ; I think we should leave the uncategorized ones to ADMIN or something
if there is a particular set of exceptions which should be hardened; maybe those should be targeted directly
There was a problem hiding this comment.
I reverted this part of the change, thanks for taking a look!
abhishekrb19
approved these changes
Jun 11, 2024
kgyrtkirk
reviewed
Jun 12, 2024
| "Unable to parse the SQL, unrecognized error from calcite: [%s]", | ||
| inner.getMessage() | ||
| ); | ||
| return InvalidSqlInput.exception(inner.getMessage()); |
There was a problem hiding this comment.
this exception creation clips the stacktrace - it only retains the source exceptions message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where in some cases, a
SqlParseExceptionencountered when parsing a query results in an error returned to the user with persona aDEVELOPERwhen it should instead beUSER.This PR has: