Add MSQ query context maxNumSegments
#16637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default is MAX_INT (unbounded). - When set and if a time chunk contains more number of segments than set in the query context, the MSQ task will fail with TooManySegments fault.
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
…ents). Also fix formatter.
abhishekrb19
force-pushed
the
msq_max_num_segments
branch
from
0246c18
to
6202bdd
Compare
cryptoe
reviewed
Jun 26, 2024
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java
Show resolved
Hide resolved
...s-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java
Outdated
Show resolved
Hide resolved
…tor-druid into msq_max_num_segments
|
Thanks for the review, @cryptoe. I renamed the validation function and also included granularity info in the error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
maxNumSegmentsthat acts as a guard rail on the maximum number of segments that can be generated by an ingestion task per time chunk. A similar parameter exists in the split hint spec supported by the native engine.Integer.MAX_INT, butnullfeels more natural.TooManySegmentsInTimeChunkFault.Most users won't need to set this config, but this will be useful in the following scenarios:
I intentionally left the context parameter and the fault undocumented. We can document it once we have a wider use case. Similarly, no release note is required for this patch.
This PR has: